Last week I kept changing the templates to the Twig format. This is necessary because having two different template formats has a negative impact on performance.
Handled issues:
The post Weekly phpMyAdmin contributions 2017-W41 appeared first on mauriciofauth.com.
Today, Gammu 1.38.5 has been released. After long period of bugfix only releases, this comes with several new noteworthy features.
The biggest feature probably is that SMSD can now handle USSD messages as well. Those are usually used for things like checking remaining credit, but it's certainly not limited to this. This feature has been contributed thanks to funding on BountySource.
You can read more information in the release announcement.
by Michal Čihař (michal@cihar.com) at October 18, 2017 10:00 AM
Last week I've continued on cleaning up common.inc.php, but there were other bug fixes as well. Most notable probably being fixing SQL parser to better handle CREATE TABLE queries defining partitions.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at October 17, 2017 10:00 AM
Weblate 2.17 has been released today. There are quite some performance improvements, improved search, improved access control settings and various other improvements.
Full list of changes:
Update: The bugfix 2.17.1 is out as well, fixing testsuite errors in some setups:
If you are upgrading from older version, please follow our upgrading instructions.
You can find more information about Weblate on https://weblate.org, the code is hosted on Github. If you are curious how it looks, you can try it out on demo server. You can login there with demo account using demo password or register your own user. Weblate is also being used on https://hosted.weblate.org/ as official translating service for phpMyAdmin, OsmAnd, Turris, FreedomBox, Weblate itself and many other projects.
Should you be looking for hosting of translations for your project, I'm happy to host them for you or help with setting it up on your infrastructure.
Further development of Weblate would not be possible without people providing donations, thanks to everybody who have helped so far! The roadmap for next release is just being prepared, you can influence this by expressing support for individual issues either by comments or by providing bounty for them.
by Michal Čihař (michal@cihar.com) at October 13, 2017 01:00 PM
For quite some time I have some cryptocurrencies on hold. These mostly come from times it was possible to mine Bitcoin on the CPU, but I've got some small payments recently as well.
I've been using Electrum wallet so far. It worked quite well, but with increasing Bitcoin value, I was considering having some hardware wallet for that. There are few options which you can use, but I've always preferred Trezor as that device is made by guys I know. Also it's probably device with best support out of these (at least I've heard really bad stories about Ledger support).
In the end what decided is that they are also using Weblate to translate their user interface and offered me the wallet for free in exchange. This is price you can not beat :-). Anyway the setup was really smooth and I'm now fully set up. This also made me more open to accept other cryptocurrencies which are supported by Trezor, so you can now see more options on the Weblate donations page.
by Michal Čihař (michal@cihar.com) at October 13, 2017 04:00 AM
Hosted Weblate provides also free hosting for free software projects. The hosting requests queue has grown too long, so it's time to process it and include new project.
This time, the newly hosted projects include:
Additionally there were some notable additions to existing projects:
If you want to support this effort, please donate to Weblate, especially recurring donations are welcome to make this service alive. You can do that easily on Liberapay or Bountysource.
by Michal Čihař (michal@cihar.com) at October 11, 2017 04:00 PM
Last week I've finally got to common.inc.php cleanup which is assigned to me for more than year. I've again managed to cleanup some parts of it, but it's quite challenging task as whenever I touch this (mostly ancient) code, I found some issues with it and have to fix other things as well.
Another interesting topic was fixing operation with database or table called 0. This is well known PHP issue that empty function in string containing just 0 will return true, however some of our code was using that to test whether database or table are set. This should be now fixed in master branch.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at October 10, 2017 10:00 AM
The #13297 issue had milestone set to 4.8.0, so last week I focused on porting the templates to Twig.
Handled issues
The post Weekly phpMyAdmin contributions 2017-W40 appeared first on mauriciofauth.com.
Upcoming Weblate 2.17 will bring improved access control settings. Previously this could be controlled only by server admins, but now the project visibility and access presets can be configured.
This allows you to better tweak access control for your needs. There is additional choice of making the project public, but restricting translations, what has been requested by several projects.
You can see the possible choices on the UI screenshot:
On Hosted Weblate this feature is currently available only to commercial hosting customers. Projects hosted for free are limited to public visibility only.
by Michal Čihař (michal@cihar.com) at October 09, 2017 04:00 PM
Upcoming Weblate 2.17 will bring improved access control settings. Previously this could be controlled only by server admins, but now the project visibility and access presets can be configured.
This allows you to better tweak access control for your needs. There is additional choice of making the project public, but restricting translations, what has been requested by several projects.
You can see the possible choices on the UI screenshot:
On Hosted Weblate this feature is currently available only to commercial hosting customers. Projects hosted for free are limited to public visibility only.
by Michal Čihař (michal@cihar.com) at October 09, 2017 04:00 PM
Stardicter 1.1, the set of scripts to convert some freely available dictionaries to StarDict format, has been released today. The biggest change is that it will also keep source data together with generated dictionaries. This is good for licensing reasons and will also allow to actually build these as packages within Debian.
Full list of changes:
As usual, you can install from pip, download source or download generated dictionaries from my website. The package should be soon available in Debian as well.
by Michal Čihař (michal@cihar.com) at October 09, 2017 01:15 PM
Last week I added a linter to the JavaScript files and fixed some code style issues. I changed the namespace of some classes to help with the organization and I moved several tests for the Util class methods to the UtilTest test class, and handled some issues and pull requests.
Handled issues:
The post Weekly phpMyAdmin contributions 2017-W39 appeared first on mauriciofauth.com.
Last week was mostly focused on catching up after two weeks of vacation. That involved quite a lot of things in our issue tracker and cleanup of pending things in pull requests.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at October 03, 2017 10:00 AM
Last week I added namespaces to all test classes, converted some template files to Twig format, added array type declarations to some function arguments, and handled some issues and pull requests.
Handled issues:
The post Weekly phpMyAdmin contributions 2017-W38 appeared first on mauriciofauth.com.
Last week I completed the refactoring of function files. I moved each function into a class as a static method. This allows us to use the autoloader to load up the class instead of using a file include.
Handled issues:
The post Weekly phpMyAdmin contributions 2017-W37 appeared first on mauriciofauth.com.
Last week was heavily focused on our Selenium tests and improving their speed and reliability. This was pretty much achieved and there seem to be no random failures now.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at September 12, 2017 10:00 AM
Last week I worked on converting function files into class files and I changed the function calls to static method calls. This allowed me to remove the include calls in favor of the autoloader, that loads the classes automatically.
Handled issues:
The post Weekly phpMyAdmin contributions 2017-W36 appeared first on mauriciofauth.com.
Last week was pretty productive on bug fixing side. These were quite varied from server monitor breakage on non Linux and Windows platforms to minor rendering issues of date selector. Quite interesting new feature is that our SQL parser now better understands to some MariaDB extensions.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at September 05, 2017 10:00 AM
Last week was again mostly spent on fixing bugs and going through reports on our error reporting server. This is really valuable tool for finding problems which hit our users, on the other side there is simply too many things there and sometimes it's hard to pinpoint something really important.
Besides that I've also ensured that all our libraries work well with upcoming PHP 7.2 and all are now tested on Travis CI against this version as well.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at August 29, 2017 10:00 AM
Here is the list of issues on which I have worked this summer.
https://github.com/phpmyadmin/phpmyadmin/issues/13023
As the number of mobile users are increasing day by day so responsive design should be implemented into phpMyAdmin.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13422
Status: Merged
https://github.com/phpmyadmin/phpmyadmin/issues/12944
It will add the feature to have an easy view of the JSON data of a column of a table. Right now it shows in only one line, without any kind of format, so we can have an option to show when you are viewing a table with JSON data or when editing a nice JSON view.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13317
Status: Merged
https://github.com/phpmyadmin/phpmyadmin/issues/12261
There are several places which uses inline javascript (like onclick, onsubmit and onchange). These should be removed and placed into javascript files. After removal we can get rid of ‘unsafe-inline’ for scripting in CSP.
Pull Requests
Status: Merged
https://github.com/phpmyadmin/phpmyadmin/issues/9419
If the import file is not in supported formats and it’s not ‘utf-8’ then it runs the SET NAMES for the selected charset during the import option. So I will disable the second time encoding if the selected charset is same as that of the charset mentioned in the SET NAMES.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13457
Status: Review
https://github.com/phpmyadmin/phpmyadmin/issues/6311
https://github.com/phpmyadmin/phpmyadmin/issues/12401
It would be really nice to have a progress bar showing import and export progress in real time in terms of percentage and having some more detailed information like which step/table it is processing.
For Export (export.php will be used)
Export Status in Percentage (including how many tables and rows have been already processed and which is in progress right now)
For Import (import.php will be used)
Upload a file and Unzip it. Import into a database (including how many tables and rows have been already processed and which is in progress right now)
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13502
Status: Review
https://github.com/phpmyadmin/phpmyadmin/issues/12718
When a user has access to a db (or table), but is not in the user table he’s shown as not having a password. Even after successfully running the query delete from mysql.user where user = ‘test’ I was still able to login with the test account.
I will show the message “NO” without red mark and with showing an information icon with a tooltip saying that the user exists in some tables but not the user table.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13305
Status: Merged
https://github.com/phpmyadmin/phpmyadmin/issues/12887
The PMA should fallback to default table names if controluser + pmadb options are set while other like ‘relation’, ‘column_info’ are NOT in config.inc.php.
So if the above conditions are matched I will make all features that are listed as Enabled instead of Disabled.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13524
Status: Merged
I have also posted the weekly update for my project. Following are the links of every week that includes the details and links to pull requests.
https://medium.com/@manishbisht/week-1-google-summer-of-code-17-with-phpmyadmin-dfa88d8bfb4a
https://medium.com/@manishbisht/week-2-google-summer-of-code-17-with-phpmyadmin-415fb3d64483
https://medium.com/@manishbisht/week-3-google-summer-of-code-17-with-phpmyadmin-906017806ac2
https://medium.com/@manishbisht/week-4-google-summer-of-code-17-with-phpmyadmin-265521adaf57
https://medium.com/@manishbisht/week-5-google-summer-of-code-17-with-phpmyadmin-e988b69d6a80
https://medium.com/@manishbisht/week-6-google-summer-of-code-17-with-phpmyadmin-7a2621f1456a
https://medium.com/@manishbisht/week-7-google-summer-of-code-17-with-phpmyadmin-74f202a73499
https://medium.com/@manishbisht/week-8-google-summer-of-code-17-with-phpmyadmin-f186d502522f
https://medium.com/@manishbisht/week-9-google-summer-of-code-17-with-phpmyadmin-90f3699459e8
https://medium.com/@manishbisht/week-10-google-summer-of-code-17-with-phpmyadmin-6bf6fb791b49
https://medium.com/@manishbisht/week-11-google-summer-of-code-17-with-phpmyadmin-72b4a18597a2
https://medium.com/@manishbisht/week-12-google-summer-of-code-17-with-phpmyadmin-2f0a77f48c93
I have also presented this project in my college also. So here it the link of the presentation https://docs.google.com/presentation/d/1-rnFgE1AIx82hgj41DfbVqflmWyyo0MOFw9L2ylF5kE/
I have learned a lot of new things. This organisation have the best community I have seen it till now. I will keep on contributing to this organisation to make phpmyadmin better.
Thanks phpyadmin for the awesome summer and special thanks to my project mentor Isaac Bennetch :)
This post summarizes the work done and tasks accomplished during the last twelve weeks. It was carried out as a part of Google Summer of Code 2017 with phpMyAdmin.
The project involved two separate sub-lists of tasks, one related to phpMyAdmin’s Error Reporting Server and the other related to phpMyAdmin’s selenium test-suite.
Tasks related to Error Reporting Server:
Tasks related to selenium testing:
Weekly reports
The detailed weekly reports are available on this blog at the following links:
Conclusion
The project led to a few good improvements to phpMyAdmin’s error reporting server, which I hope would make it more developer-friendly and the public interface would help more non-team contributors in fixing the errors reported on it.
phpMyAdmin’s selenium test-suite has finally stabilized in green (i.e. passing), albeit some errors popping up once in about ten runs. I do hope to fix these as they are encountered. Improvement in selenium test-suite and moving it out of allowed failures in Travis has already started to show its impact as we could track a few errors introduced while refactoring. These would otherwise be missed as the refactored code was not well-covered by the unit tests.
Finally, it has been another wonderful summer working with phpMyAdmin and its wonderful community. I would like to thank my mentor, Michal Čihař and the entire phpMyAdmin team, for their continued support throughout this project.
Hosted Weblate provides also free hosting for free software projects. The hosting requests queue has grown too long, so it's time to process it and include new project.
This time, the newly hosted projects include:
If you want to support this effort, please donate to Weblate, especially recurring donations are welcome to make this service alive. You can do them on Liberapay or Bountysource.
by Michal Čihař (michal@cihar.com) at August 25, 2017 04:00 PM
Week #12
Key accomplishments last week:
Key tasks stalled:
NA
Tasks in the upcoming week:
Details:
I completed one of the tasks left in the proposal that was about adding selenium tests for covering phpMyAdmin’s Query by example UI. Additionally, I continued to try and make phpMyAdmin’s selenium test-suite more robust.
Another GSoC student Raghuram has been working on developing the new UI for Query by example as a part of his project. His PR with those changes just got merged yesterday, but the selenium tests might have to be adjusted to suit this new UI. Apart from this, the selenium test-suite is on the verge of running successfully over a set of continuous commits.
With this week coming to an end, the offical coding period for GSoC ’17 has also ended. I would be discussing with my mentor Michal to decide on what to submit as the final submission. It would mostly be a summary post with relevant links and description on this blog.
Since some time we're using siphash algorithm to speed up looking up strings in Weblate. Even though it is used by Python internally, it's not exposed in the standard library so several third party modules appeared in the PyPI. Out of all these siphashc or rather it's Python 3 fork siphashc3 seemed to perform best, so I've started to use that.
However it turned out that none of them is in active maintenance anymore. The original version lacks Python 3 support, while the siphashc3 uses odd versioning which causes problems to some pip versions.
After trying to get fix into siphashc3 without much of success, I've spoken to original author of siphashc and he has agreed to hand over maintainership to me. So it's new home is at https://github.com/WeblateOrg/siphashc and new release is already available on PyPI.
Note: Originally we were using MD5 in Weblate, but siphash has shown to be faster and fits into 64-bits, what makes it easier to store and index in SQL databases as LONGINT.
by Michal Čihař (michal@cihar.com) at August 24, 2017 04:00 PM
So, finally I made it to the end of my project. It was a great experience working with phpMyAdmin through the summer. Since final evaluations are drawing close, Isaac suggested me to make a blog post of links to all the pull requests I submitted. That makes this post an official artifact of my GSoC project. I am glad that I was able to stick to the proposed plan for the most part. Towards the end, we had to re-plan slightly. I am thankful to my mentor for being very supportive during this time.
The following is the list of Pull Requests I submitted in chronological order:
As I mentioned in an earlier post, I was not able to implement one of the features. But the work I did towards it can be found at –
https://github.com/phpmyadmin/phpmyadmin/compare/master…Achilles-96:Setup-Improvements
One of the issues was resolved without any code submission –
https://github.com/phpmyadmin/phpmyadmin/issues/12845
Last week was a bit less intensive on bug fixes, but I've spent quite a lot of time on improving our localized documentation and fixing various errors there. This is really something what should be automatically checked in Weblate in the long term, but right now it results in build failures in Travis.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at August 22, 2017 10:00 AM
Previous week the tasks mentioned in my proposal was completed so this week was mostly spent in debugging, checking and fixing other issues. I have fixed one more issue this week.
https://github.com/phpmyadmin/phpmyadmin/issues/13572
This is the method to create the error message
$error = PhpMyAdmin\Message::error(__('No tables found in database.'));So the following was the final result.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13585
This was my last week progress. I will post an update for wrap up of the entire GSoC tasks in the upcoming week.
Week #10 – 11
Key accomplishments last week:
Key tasks stalled:
NA
Tasks in the upcoming week:
Details:
I spent some time last week to make the test-suite more robust. Last I had written it was throwing a lot of unrelated errors, but that has been fixed now. It felt really good to see the ‘Daily update’ mails from Browerstack for last two days which said ‘No builds had issues’, which seems to be pointing to suite been stabilized for a few consecutive builds.
Last week was spent at DebConf’17 in Montreal, Canada. Madhura, Michal and I were attending the conference and we managed to meet up with Marc for lunch on one of the days. I did manage to find some time and added selenium tests for typing and executing SQL queries. This covers the Server, Database and Table SQL pages and in-line editing of SQL queries on results page.
For this current week, I plan to continue working to making the selenium test-suite consistent to pass on every commit and prevent any non-deterministic errors. This coming week would be the last week working before pencils-down date. I do expect to continuing some work towards the test-suite to surely go on.
I've spent last week on DebConf, where main motivation to come was to meet with other phpMyAdmin team members. Besides that we've met with Marc, former phpMyAdmin lead.
On the coding side, it was pretty much just reviewing pull requests and some minor fixes.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at August 15, 2017 10:00 AM
Hosted Weblate provides also free hosting for free software projects. The hosting requests queue was over one month long, so it's time to process it and include new project.
This time, the newly hosted projects include:
If you want to support this effort, please donate to Weblate, especially recurring donations are welcome to make this service alive. You can do them on Liberapay or Bountysource.
by Michal Čihař (michal@cihar.com) at August 14, 2017 10:00 AM
This week I have spent my time working on following issue:
https://github.com/phpmyadmin/phpmyadmin/issues/6311
https://github.com/phpmyadmin/phpmyadmin/issues/12401
The export and import progress bar is now complete. Here are the screenshots of the final result.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13502
This was my eleventh week progress. I will post an update for this week soon.
First of all, I successfully passed my second evaluations. Thanks to my mentor. 
The reason I didn’t blog since then is that there was not much progress. Reopening of my college and registration took up more time than expected. Adding to the trouble, my next task Setup improvements turned out be more challenging than expected. It was not suggested in the initial project enhancements collection. But I added it as I felt it is important feature and a good replacement for the other task – Filling random test data in database. Why I had to replace? That’s another story.
Coming to the point, allowing access to file-system is a sensitive issue. After a lot of discussion with Michal, we finally agreed on following scheme for allowing access to setup:
config.inc.php and it can be written to, redirect user to setup and force him creating config at least with setup password. This will make the attack window minimal as most people will try to access the tool just after installing.Access to setup:
And this was finalized just last week. Also, I came across a few existing bugs after starting to work on setting up the credential-setup. These bugs further added to delay. I had to fix them and proceed. Current standpoint is that credential-setup is still not completely done. There is one more issue I ran into. The config options which I applied are not reflecting in the generated config file. I and Isaac are working to resolve this. You can check out work in progress by checking out my branch. Now it is clear that my idea for Setup Improvements was ambitious. I talked with Isaac about this. He understood the situation as the pencils down time is approaching. Now I plan to just implement editable configuration completely for this task.
Weblate 2.16 has been released today while I'm at DebConf17. There are quite some performance improvements (and more of that is scheduled for 2.17), new file formats support and various other improvements.
Full list of changes:
If you are upgrading from older version, please follow our upgrading instructions.
You can find more information about Weblate on https://weblate.org, the code is hosted on Github. If you are curious how it looks, you can try it out on demo server. You can login there with demo account using demo password or register your own user. Weblate is also being used on https://hosted.weblate.org/ as official translating service for phpMyAdmin, OsmAnd, Turris, FreedomBox, Weblate itself and many other projects.
Should you be looking for hosting of translations for your project, I'm happy to host them for you or help with setting it up on your infrastructure.
Further development of Weblate would not be possible without people providing donations, thanks to everybody who have helped so far! The roadmap for next release is just being prepared, you can influence this by expressing support for individual issues either by comments or by providing bounty for them.
by Michal Čihař (michal@cihar.com) at August 11, 2017 01:30 PM
This week was quite productive in terms of bug fixes and various code improvements. One of most visible things is probably PHP 7.2 compatibility, but there were other fixes as well.
I've somehow failed to post this report on time, so sorry for late publishing.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at August 08, 2017 10:00 AM
This week I have spent my time working on following issue:
https://github.com/phpmyadmin/phpmyadmin/issues/6311
https://github.com/phpmyadmin/phpmyadmin/issues/12401
The export progress is completed and updated in the PR and currently working on the import progress.
For Import the data is saving in the configuration database. I am now looking for the way to update the import progress on the page.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13502
The following issue was due to the responsive design. So I have fixed this also.
https://github.com/phpmyadmin/phpmyadmin/issues/13546
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13549
This was my tenth week progress. I will post an update for this week soon.
I've made several changes to the Weblate Docker container which are worth mentioning today.
First of all if you are still using nijel/weblate, you should switch to weblate/weblate. They both currently share same configuration, but it might happen that some future updates will go to the weblate owned container only.
Now back to the container changes. Since beginning we were using Django built in server. That's fine for development purposes, but it really doesn't work that well in production as it can handle only one request at time. Therefore we've switched to more robust approach using nginx + uwsgi + supervisor.
Thanks to this, the docker-compose no longer needs separate nginx server as everything is now sanely handled within the weblate container itself.
by Michal Čihař (michal@cihar.com) at August 04, 2017 10:00 AM
After fours years, I will again make it to DebConf, I'm looking forward to meet many great people, so if you want to meet and happen to be in Montreal next week come and say hello to me :-).
It seems I've settled down on four year schedule - I've attended DebConf09 and DebConf13 so far. Let's see if next one will come in 2021 or earlier.
Filed under: Debian English Gammu phpMyAdmin Weblate
by Michal Čihař (michal@cihar.com) at August 03, 2017 04:00 AM
Week #9
Key accomplishments last week:
Key tasks stalled:
NA
Tasks in the upcoming week:
Details:
I spent some time last week to make the test-suite more robust and it actually did stabilize for a few consecutive builds. I also spent some time to add code in our test-suite so that the failed tests on Travis are actually marked with a failed status on Browerstack.
For this current week, I plan to continue working to making the selenium test-suite consistent to pass on every commit and prevent any non-deterministic errors. For the last two days, it has started to throw a lot of errors suddenly (which I am really not sure why it is happening). I might also start to implementing the new selenium tests to be added for typing and executing a sql query on table, database and server SQL pages.
This week I have spent my time working on following issue:
https://github.com/phpmyadmin/phpmyadmin/issues/12887
I check the control user and control values and if both values are set the n I set the default values for table and database.
if ($GLOBALS['cfg']['Server']['controluser'] &&
$GLOBALS['cfg']['Server']['controlpass']) {
// Set the default table name and database
}
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13524
https://github.com/phpmyadmin/phpmyadmin/issues/6311
https://github.com/phpmyadmin/phpmyadmin/issues/12401
The export progress bar is almost done. I am now waiting for the feedback on the PR and in parallel started working on the import progress bar.
Pull Request: https://github.com/phpmyadmin/phpmyadmin/pull/13502
This was my ninth week progress. I will post an update for this week soon.
Weblate 2.16 is almost ready (I expect no further code changes), so it's really great time to contribute to it's translations! Weblate 2.16 will be probably released during my presence at DebConf 17.
As you might expect, Weblate is translated using Weblate, so the contributions should be really easy. In case there is something unclear, you can look into Weblate documentation.
I'd especially like to see improvements in the Italian translation which was one of the first in Weblate beginnings, but hasn't received much love in past years.
by Michal Čihař (michal@cihar.com) at July 27, 2017 10:00 AM
Week #8
Key accomplishments last week:
Key tasks stalled:
NA
Tasks in the upcoming week:
Details:
Last week was cut short since I was travelling to attend my convocation ceremony at the BITS Pilani, Pilani campus. I graduated in the first division with a dual degree in M. Sc. (Hons.) Economics and B. E. (Hons.) Computer Science.
I spent the last week fixing the selenium tests related to Export, Table, Tracking, XSS. The related PR was made and merged at #13520. The test-suite is able to run successfully and finally I got a few successful selenium travis jobs after a long time, though I am still fixing some or the other error that keeps popping up on some jobs.
For this current week, I plan to continue working to making the selenium test-suite consistent to pass on every commit and prevent any non-deterministic errors. I would also want to explore a possibility to migrate the selenium tests to use Facebook’s php-webdriver.
Last week was really focused on fixing issues on phpMyAdmin itself. Some of them also lead to me to bigger cleanups, for example in theme management code, which is now not relying on session cache.
Another important improvements were focused on improving SSL support in phpMyAdmin. It is now able to automatically detect if server enforces SSL and enable it in such case. There is also improved documentation about configuring SSL.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at July 25, 2017 10:00 AM
All are probably familiar with vpn.iiit.ac.in. It clearly details steps to follow for setting up IIIT VPN which includes going through a series of steps every time you want to connect. So, I made this small procedure to automate it.
/etc/openvpn/ directory. ca.crt, all.iiit.ac.in.crt, all.iiit.ac.in and linux_client.conf. (You need to be root to be able to write in this directory).etc/openvpn/. Create a file called login.conf and add your IIIT email ID in first line and password in second line. For security, make it accessible only to root:
sudo chown root login.conf sudo chgrp root login.conf #Not really needed sudo chmod 400 login.conf
linux_client.conf. Find line which says auth-user-pass(should be around line 126). Replace the line with auth-user-pass login.conf..bashrc. Copy the following lines at the end of it.
#This function is helpful if you want to run any function as root.
function execsudo ()
{
### ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##
#
# LOCAL VARIABLES:
#
### ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##
#
# I use underscores to remember it's been passed
local _funcname_="$1"
local params=( "$@" ) ## array containing all params passed here
local tmpfile="/dev/shm/$RANDOM" ## temporary file
local filecontent ## content of the temporary file
local regex ## regular expression
local func ## function source
### ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##
#
# MAIN CODE:
#
### ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##
#
# WORKING ON PARAMS:
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#
# Shift the first param (which is the name of the function)
unset params[0] ## remove first element
# params=( "${params[@]}" ) ## repack array
#
# WORKING ON THE TEMPORARY FILE:
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
content="#!/bin/bash\n\n"
#
# Write the params array
content="${content}params=(\n"
regex="\s+"
for param in "${params[@]}"
do
if [[ "$param" =~ $regex ]]
then
content="${content}\t\"${param}\"\n"
else
content="${content}\t${param}\n"
fi
done
content="$content)\n"
echo -e "$content" > "$tmpfile"
#
# Append the function source
echo "#$( type "$_funcname_" )" >> "$tmpfile"
#
# Append the call to the function
echo -e "\n$_funcname_ \"\${params[@]}\"\n" >> "$tmpfile"
#
# DONE: EXECUTE THE TEMPORARY FILE WITH SUDO
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sudo bash "$tmpfile"
disown 2> /dev/null
rm "$tmpfile"
}
function vpnfunc {
echo "Starting VPN!!"
cd /etc/openvpn
openvpn --config linux_client.conf | while read line
do
[[ "${line}" == *"Initialization Sequence Completed"* ]] && echo 'nameserver 10.4.20.204' | cat - /etc/resolv.conf > temp && mv temp /etc/resolv.conf && echo 'Started VPN successfully!!' && kill -STOP $$
done
}
function startvpn {
exec 3>&2 # 3 is now a copy of 2
exec 2> /dev/null # 2 now points to /dev/null
execsudo vpnfunc # run script with redirected stderr
exec 2>&3 # restore stderr to saved
exec 3>&- # close saved version
}
function stopvpn {
sudo killall openvpn
sudo sed -i '/nameserver 10.4.20.204$/d' /etc/resolv.conf
}
source .bashrc.startvpn command should start your VPN. (It may ask for sudo password).stopvpn will terminate VPN.I am not a bash God, so please spare me if I made any blunders. But, do leave a comment if it can be done better.
Credits for execsudo function: stackoverflow answer
This week I have spent my time working on following issue:
https://github.com/phpmyadmin/phpmyadmin/issues/6311
https://github.com/phpmyadmin/phpmyadmin/issues/12401
First I made changes in the phpmyadmin configuration sql table and added one extra table to track the progress status.
CREATE TABLE IF NOT EXISTS `pma__progress` (
`uuid` varchar(36) NOT NULL,
`type` varchar(64) NOT NULL,
`data` text NOT NULL,
`value` int(50) unsigned NOT NULL,
`total` int(50) unsigned NOT NULL,
UNIQUE KEY `uuid` (`uuid`)
)
COMMENT='Saved import/export progress data'
DEFAULT CHARACTER SET utf8 COLLATE utf8_bin;
Then I learnt how to insert data in phpmyadmin configuration database. Then from the mailing list I got this link to get started
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/tracking.lib.php#L246 So finally I was able to update data in the progress table as the new table is exported.
$cfgRelation = PMA_getRelationsParam();
$sql_query = " SELECT * FROM " .
PhpMyAdmin\Util::backquote($cfgRelation['db']) . "." .
PhpMyAdmin\Util::backquote($cfgRelation['tracking']) .
" WHERE db_name = '" .
$GLOBALS['dbi']->escapeString($_REQUEST['db']) . "' " .
" AND table_name = '" .
$GLOBALS['dbi']->escapeString($_REQUEST['table']) . "' " .
" ORDER BY version DESC ";
PMA_queryAsControlUser($sql_query);
Then I used the setInterval() to update the progress on the page.
var progressInterval = setInterval(function () {
$.post('progress.php', params, function (response) {
if (response.success === true) {
// do something
}
});
}, 500);And the final result was something like this.
One more thing I missed mentioning below issue in my previous blog post. This was completed last week.
https://github.com/phpmyadmin/phpmyadmin/issues/9419
https://github.com/phpmyadmin/phpmyadmin/pull/13457
I have used phpmyadmin sql parser to do this.
use PhpMyAdmin\SqlParser\Parser;
use PhpMyAdmin\SqlParser\Utils\Query;
$query = 'SET NAMES latin1';
$parser = new Parser($query);
$flags = Query::getFlags($parser->statements[0]);
echo $flags['querytype'];
This was my eighth week progress. I will post an update for this week soon.
This week, there is nothing much to update. It turned out that my previous task i.e., to consolidate table sorter libraries used by phpMyAdmin is not needed. The reason being the two libraries mentioned in the task are independent of each other and do not do the same task. I am getting code reviews on my previously submitted patches. I will be working on them those patches this week and hopefully get some of them merged.
The following are the patches I submitted so far:
Having publicly running web application always brings challenges in terms of security and in generally in handling untrusted data. Security wise Weblate has been always quite good (mostly thanks to using Django which comes with built in protection against many vulnerabilities), but there were always things to improve in input validation or possible information leaks.
When Weblate has joined HackerOne (see our first month experience with it), I was hoping to get some security driven core review, but apparently most people there are focused on black box testing. I can certainly understand that - it's easier to conduct and you need much less knowledge of the tested website to perform this.
One big area where reports against Weblate came in was authentication. Originally we were mostly fully relying on default authentication pipeline coming with Python Social Auth, but that showed some possible security implications and we ended up with having heavily customized authentication pipeline to avoid several risks. Some patches were submitted back, some issues reported, but still we've diverged quite a lot in this area.
Second area where scanning was apparently performed, but almost none reports came, was input validation. Thanks to excellent XSS protection in Django nothing was really found. On the other side this has triggered several internal server errors on our side. At this point I was really happy to have Rollbar configured to track all errors happening in the production. Thanks to having all such errors properly recorded and grouped it was really easy to go through them and fix them in our codebase.
Most of the related fixes have landed in Weblate 2.14 and 2.15, but obviously this is ongoing effort to make Weblate better with every release.
by Michal Čihař (michal@cihar.com) at July 21, 2017 10:00 AM
Last week was quite busy and that can be seen from number of issues. Some of them are coming from our error reporting server, where I've focused on the most frequently happening ones for last releases. Still there is about 30000 reports to handle there.
There were several fixes to our SQL parser as well, apparently it's already being used by some other tools, for example by php-sqllint, so we're getting more bug reports :-).
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at July 18, 2017 10:00 AM
Week #7
Key accomplishments last week:
Key tasks worked on:
Key tasks stalled:
NA
Tasks in the upcoming week:
Details:
I spent the last week fixing the selenium tests related to Login, Normalization, ChangePassword, ServerSettings. The related PR was made and merged at #13476.
In the later part of the week, I spent some time fixing the table-related tests, tracking-related tests and export-related tests. Though, they are not in a consistently fixed state (i.e. they sometimes do misbehave, leading to a failure), I expect them to be ready for a PR soon.
For the next week, I plan to continue working to fixing the next set of broken selenium tests.
This week I have spent my time working on following issue:
https://github.com/phpmyadmin/phpmyadmin/issues/12944
https://github.com/phpmyadmin/phpmyadmin/pull/13435
This is how to check the string is in JSON format of not.
function isJsonString(str) {
try {
JSON.parse(str);
} catch (e) {
return false;
}
return true;
}https://github.com/phpmyadmin/phpmyadmin/issues/12261
https://github.com/phpmyadmin/phpmyadmin/pull/13446
I uses the following code to remove remove javascript.
$(selector).click(function() {
//do something
});https://github.com/phpmyadmin/phpmyadmin/issues/6311
https://github.com/phpmyadmin/phpmyadmin/issues/12401
I tried solving this issue by setting the cookie and the retriving the cookie to show the progress but the setcookie() in php failed when used after setting the header.
So as this doesn’t worked I have now created a new table in phpMyAdmin Configuration Storage database. I am running behind my timeline as this seems to be difficult compared to my expectations.
This next week issue https://github.com/phpmyadmin/phpmyadmin/issues/12718 has already been resolved my me during the community bonding period so I expect this to complete it by this week.
This was my seventh week progress. I will post an update for this week soon.
This week, I worked on adding two-factor authentication support for phpMyAdmin. This is by far the most interesting feature I worked on. I never really worked keenly on the security aspect of any software. This indeed has been a very good learning experience. 
Here is the process:
I am yet to add a way to delete 2-factor authentication. You can check-out the code from my branch. I will make a pull request after I add the deletion part also.
Since this is a security feature, I feel this requires thorough testing.
Special thanks to TwoFactorAuth library.
Edit: Submitted pull request – https://github.com/phpmyadmin/phpmyadmin/pull/13495
Last week was a bit shorted for me due to public holidays, but still there is new release of SQL parser and some other minor bug fixes.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at July 11, 2017 10:00 AM
Week #6
Key accomplishments last week:
Key tasks stalled:
NA
Tasks in the upcoming week:
Details:
Based on Michal’s review in the first GSoC evaluations, I worked on improving the test coverage of the Error Reporting Server codebase. The code coverage has improved significantly from 47% to 83% during this week. It now covers most of the important functionalities and we should be able to catch any breakages due to code changes in future.
Apart from that, I started on the second part of my proposal which deals with fixing the broken selenium testing suite in phpMyAdmin. I have fixed around fifteen tests of around fifty five tests which we have. I have made a PR at #13462. Once all the selenium tests are fixed, I plan on adding a few more to cover some other important actions that have not been covered till now.
For the next week, I plan to continue working to fixing the next set of broken selenium tests.
This week also I have submitted the PR and worked on fixing few small issues for the following responsive task:
https://github.com/phpmyadmin/phpmyadmin/issues/6241
https://github.com/manishbisht/phpmyadmin/commit/b4a0c8a2b74b827a8e4cab7e8d7af30d874023a8 https://github.com/phpmyadmin/phpmyadmin/wiki/Icons_Sprites_Usage
cd /path/to/phpmyadmin ./scripts/generate-sprites .
https://github.com/manishbisht/phpmyadmin/commit/a06521247519bc079cbb3b7df47a9e606ac5b108
https://github.com/manishbisht/phpmyadmin/commit/375530e799c378c7fbc225c2ad2aa04b22a4e3f2
https://github.com/manishbisht/phpmyadmin/commit/7195846c83c971adca68913388594457259bcac5
https://github.com/phpmyadmin/phpmyadmin/wiki/Unit_Testing
./vendor/bin/phpunit -c phpunit.xml.nocoverage --exclude-group selenium
https://github.com/manishbisht/phpmyadmin/commit/bdee1b401d67562f3e75eee118f89d6646032e51
https://github.com/manishbisht/phpmyadmin/commit/3bd50986b4463f7b055c2d4e37ea4a0b29dea422
https://github.com/manishbisht/phpmyadmin/commit/11c95a1292753ba7a8e8e514de7030fb870e0613
https://github.com/manishbisht/phpmyadmin/commit/26c37531edcc00c2db66876b7cd35ee1933a5b95
I have submitted the PR so that the code can be reviewed and merged into master. https://github.com/phpmyadmin/phpmyadmin/pull/13422
From now onward I will be working on fixing the other bugs while in parallel fixing any bugs that will come in responsive task during review.
This was my sixth week progress. I will post an update for this week soon.
I am late to update the blog this week. Sorry for that.
First, I want to talk about first evaluations whose results came out on 30th. I have successfully passed the evaluations. My mentor gave me a very postive feedback which is really motivating.
Few updates about past work:
Allow designer to show other Databases: This is the issue I am working on currently. I must say this is what also caused my delayed posting. Earlier this week, while meddling with some server-related stuff, I accidentally lost my repository. I was able to retain all the branches I pushed online. Since I didn’t push this one, I was unable to recover my work. Anyway, I am able to catch up after that. Learnt a lesson to push the code as soon as I am done for the day.
Cutting to the chase, here is the screenshot:
So, as discussed, I added an option in designer side menu (I copied some other icon since we didn’t decide on one) which on clicking opens a dialog. You can select the db and the table you want to add. When you submit it, your new table is added. You can create relationships like any other table and the created relationships get stored. This is the basic functionality and it is done. The problem is that once the page is saved or reloaded, only the tables in current db appear back. According to the solution we decided, we need to show the tables in other db to which there are relations by default from the beginning. That should solve everything. This is not a big problem and I will fix it by the weekend.
Last week was really about solving bug and pull request. I've managed to go through many of long pending pull requests and most of them were merged either directly or with additional fixes.
I always feel bad when it takes too long to merge pull request, but most of them were actually waiting for some fixes which didn't arrive and I had to fix them on my own. This is often what happens to GSoC students pull requests once they realize they were not accepted in the end...
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at July 04, 2017 10:00 AM
This week also I have spent my time working on following issue:
https://github.com/phpmyadmin/phpmyadmin/issues/6241
I have made the following pages responsive.
https://github.com/manishbisht/phpmyadmin/commit/65edfc8f5b5f278205ddcdf450dd8a3a862fc7b6
While working with this page I found one issue that if there are multiple div which I have to make responsive on the same page then working with div id will failed so I replaced all the div with id=”responsivetable” with class=”jsresponsive”
https://github.com/manishbisht/phpmyadmin/commit/b39dcf2ffc34c55acbbc7c66ffe74a0806ee6735
https://github.com/manishbisht/phpmyadmin/commit/0f7cbab62e9a756214bc2c60966eedead026dd24
https://github.com/manishbisht/phpmyadmin/commit/94a13cae88a2318ce915716b227d52fa0ef05485
https://github.com/manishbisht/phpmyadmin/commit/7fe13bc8e05852176b14a9589e655d4d0842ff50
https://github.com/manishbisht/phpmyadmin/commit/85003f61a167d72130fe1123d3f7228d1f279dc4
https://github.com/manishbisht/phpmyadmin/commit/0435674c2d33e98c67a923f0940a3e0fa71ceb41
https://github.com/manishbisht/phpmyadmin/commit/66db4a1f29c9ac69052d5e7ab53a8219218076ef
https://github.com/manishbisht/phpmyadmin/commit/a154015623f6e41c8f9664c4008a886caf44f96a
https://github.com/manishbisht/phpmyadmin/commit/1a6479b311b88264889854cbaa1b35035758ae4a
https://github.com/manishbisht/phpmyadmin/commit/74119c5cd55a75515edd6bb430c29067f0bbb042
https://github.com/manishbisht/phpmyadmin/commit/bd887d8464db824e273d2900e1781dee7564eeb7
I will submit the PR soon after doing little bit fixing on navigation bar.
This was my fifth week progress. I will post an update for this week soon.
Week #5
Key accomplishments last week:
Key tasks stalled:
NA
Tasks in the upcoming week:
Note: All these tasks were related to phpMyAdmin’s Error Reporting System (Github).
Details:
#159 brings the functionality of updating report status according to the Github issue’s state to which it is being linked to. Thus, if we link the report to a Github issue which is closed, we should automatically update the Report status to ‘Resolved’.
#160 implements a controller action (which should be run as cron job from command line) to synchronise the statues of existing linked reports to statues of the linked Github issues. This action can be (and should be) only run from shell.
#74 implements a read-only public interface which allows non-team developers and contributors to look at the submitted error incidents and reports, though they would not be able to make any changes to the reports such as changing its status, linking/unlinking from a Github issue etc.
For the next week, based on Michal’s review, I would be adding some tests to the Error reporting server so that we add a few more controller/models/shells to the test coverage. I have already made two PRs at #168 and #170 in those directions. Once these (and a few more to come) are merged, I would be moving to starting to fix broken selenium testing in phpMyAdmin.
Weblate 2.15 has been released today. It is slightly behind schedule what was mostly caused by my vacation. As with 2.14, there are quite a lot of security improvements based on reports we got from HackerOne program and various new features.
Full list of changes:
If you are upgrading from older version, please follow our upgrading instructions.
You can find more information about Weblate on https://weblate.org, the code is hosted on Github. If you are curious how it looks, you can try it out on demo server. You can login there with demo account using demo password or register your own user. Weblate is also being used on https://hosted.weblate.org/ as official translating service for phpMyAdmin, OsmAnd, Turris, FreedomBox, Weblate itself and many other projects.
Should you be looking for hosting of translations for your project, I'm happy to host them for you or help with setting it up on your infrastructure.
Further development of Weblate would not be possible without people providing donations, thanks to everybody who have helped so far! The roadmap for next release is just being prepared, you can influence this by expressing support for individual issues either by comments or by providing bounty for them.
by Michal Čihař (michal@cihar.com) at June 30, 2017 09:00 AM
Last week was a bit less intensive for me, still there were some bugs fixed.
Most of the time was spent on investigating one report from error reporting server. These errors do not come from our code, but we see them in thousands, so apparently something widely spread. The feature seems to come from DirectAdmin, but I've found occurrences elsewhere as well.
I think this exactly shows why you should upstream your patches - it would get proper upstream review and you would not have to maintain it over years (apparently they have five versions of the patch in their patches directory).
Anyway pretty much same will be possible to achieve with single line of configuration in the 4.8.0 release.
Handled issues:
Filed under: English phpMyAdmin
by Michal Čihař (michal@cihar.com) at June 27, 2017 10:00 AM
Week #4
Key accomplishments last week:
NA
Key tasks worked on:
Key tasks that stalled:
NA
Tasks in the upcoming week:
Note: All these tasks were related to phpMyAdmin’s Error Reporting System (Github).
Details:
#159 aims to bring the functionality of updating report status according to the Github issue’s state to which it is being linked to. Thus, if we link the report to a Github issue which is closed, we should automatically update the Report status to ‘Resolved’. I have made a PR at #163 which is open for review.
#160 aims to implement a controller action (which should be run as cron job from command line) to synchronise the statues of existing linked reports to statues of the linked Github issues. We could have also implemented a shell to do this task but I could not easily figure out how to use GithubApiComponent (without requiring to do the additional refactoring of moving it to a Utility class). So I added a cron-dispatcher which can be run from command line and takes command line argument to run the specified controller action.
For the next week, I would be making changes based on Michal’s review for on my PRs for the above mentioned tasks. I have already started initial discussion and ground work towards the last task on Error Reporting Server (after which I would be moving to fixing selenium testing in phpMyAdmin) of #74.
Planet phpMyAdmin aggregates blogs of following phpMyAdmin contributors.
Dan Ungureanu
Deven Bansod
Madhura Jayaratne
Manish Bisht
Maurício Meneghini Fauth
Raghuram Vadapalli
October 20, 2017 10:00 AM
All times are UTC.
![[RSS 1.0 Feed]](images/rss10.png){kind=small}
![[RSS 2.0 Feed]](images/rss20.png){kind=small}
![[Atom Feed]](images/atom.png){kind=small}
![[FOAF Subscriptions]](images/foaf.png){kind=small}
![[OPML Subscriptions]](images/opml.png){kind=small}
![[Venus]](images/venus.png){kind=small}